feat: Implement persistent message type in Java #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonAndell
requested review from
redlarva,
ibrizsabin and
nightowl121
as code owners
github-actions
bot
added
the
documentation
AntonAndell
changed the base branch from
main
to
development/177-xcall-future-proof-messaging
github-actions
bot
removed
the
documentation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development/177-xcall-future-proof-messaging #215 +/- ##
==================================================================================
+ Coverage 68.58% 68.68% +0.09%
Complexity 62 62
==================================================================================
Files 39 39
Lines 2187 2184 -3
Branches 29 28 -1
==================================================================================
Hits 1500 1500
+ Misses 673 671 -2
+ Partials 14 13 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AntonAndell
force-pushed
the
185-java-implement-persistent-message
branch
from
9613afc
to
bf639c1
Compare
AntonAndell
changed the title
ibrizsabin
reviewed
Dec 19, 2023
contracts/javascore/xcall/src/main/java/foundation/icon/xcall/CallServiceImpl.java
Outdated
Show resolved
Hide resolved
ibrizsabin
reviewed
Dec 19, 2023
contracts/javascore/xcall/src/test/java/foundation/icon/xcall/CallServiceTest.java
Show resolved
Hide resolved
AntonAndell
force-pushed
the
185-java-implement-persistent-message
branch
from
bf639c1
to
e5be598
Compare
github-actions
bot
added
the
documentation
AntonAndell
force-pushed
the
185-java-implement-persistent-message
branch
from
e5be598
to
7cf576e
Compare
ibrizsabin
approved these changes
Dec 20, 2023
ibrizsabin
merged commit 3569416
into
development/177-xcall-future-proof-messaging
13 checks passed
bishalbikram
pushed a commit
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: